Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust size of reply prompt on native #4256

Merged

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented May 29, 2024

Why

This is a follow up to #4254. It became even more apparent to me how big the reply prompt is on native once the header was always there. This PR adjusts the height of this prompt.

Web

Before After
Screenshot 2024-05-29 at 12 42 33 AM Screenshot 2024-05-29 at 12 54 26 AM

Native

Before After
Screenshot 2024-05-29 at 12 47 49 AM Screenshot 2024-05-29 at 12 54 32 AM

Copy link

render bot commented May 29, 2024

@haileyok haileyok changed the base branch from main to hailey/native-header-in-post-thread May 29, 2024 07:48
@haileyok haileyok changed the title always show header on native Adjust size of reply prompt on native May 29, 2024
Copy link

github-actions bot commented May 29, 2024

Old size New size Diff
7.23 MB 7.23 MB 73 B (0.00%)

@gaearon gaearon merged this pull request into hailey/native-header-in-post-thread May 30, 2024
6 checks passed
@gaearon gaearon deleted the hailey/adjust-size-reply-prompt branch May 30, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants