-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Italian localizations #4258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22 reviews, mostly typo corrections.
@Titianbeetle I apologise for butting in, I wanted to mention something that I only figured out how to do myself relatively recently that might be helpful to you. When you're reviewing a translation and you want to suggest an alternative, you can click the button with the + and - symbols on a page and type in your suggestion: It's then very easy for the PR owner to accept it with one click if they're happy with your suggested change. |
@surfdude29 I'm not clear on the syntax of strings like this |
This one is doubly confusing because the first social-app/src/view/com/util/post-ctrls/PostCtrls.tsx Lines 246 to 255 in d614f6c
So looking at the translations already done it seems like the verb should be translated as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few other suggested changes, hopefully at least some of them are correct
Is this one good to go? |
@pfrazee for me yes! |
Sorry did you intend to close this PR? |
No, I'm sorry, I made a mistake, in reporting other changes I closed this PR by mistake, but I just wanted to realign my fork. I would like to merge it. |
Cool no worries! |
cc @Titianbeetle