Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Italian localizations #4258

Closed

Conversation

marcomaroni-github
Copy link
Contributor

Copy link
Contributor

@Titianbeetle Titianbeetle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22 reviews, mostly typo corrections.

src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
@surfdude29
Copy link
Contributor

@Titianbeetle I apologise for butting in, I wanted to mention something that I only figured out how to do myself relatively recently that might be helpful to you.

When you're reviewing a translation and you want to suggest an alternative, you can click the button with the + and - symbols on a page and type in your suggestion:

IMG_5534

It's then very easy for the PR owner to accept it with one click if they're happy with your suggested change.

@marcomaroni-github
Copy link
Contributor Author

@surfdude29 I'm not clear on the syntax of strings like this
"{0, plural, one {Like (# like)} other {Like (# likes)}}"
what are the words that need to be translated?

@surfdude29
Copy link
Contributor

surfdude29 commented May 31, 2024

@surfdude29 I'm not clear on the syntax of strings like this
"{0, plural, one {Like (# like)} other {Like (# likes)}}"
what are the words that need to be translated?

This one is doubly confusing because the first Like is a verb and like/likes is a noun. The context is that this is the accessibilityLabel for the Like button on posts:

accessibilityLabel={
post.viewer?.like
? plural(post.likeCount || 0, {
one: 'Unlike (# like)',
other: 'Unlike (# likes)',
})
: plural(post.likeCount || 0, {
one: 'Like (# like)',
other: 'Like (# likes)',
})

So looking at the translations already done it seems like the verb should be translated as Mi piace but I'm not clear what the noun for like/likes is, is it also Mi piace? 🤔

Copy link
Contributor

@surfdude29 surfdude29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few other suggested changes, hopefully at least some of them are correct

src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
src/locale/locales/it/messages.po Outdated Show resolved Hide resolved
@pfrazee
Copy link
Collaborator

pfrazee commented Jun 5, 2024

Is this one good to go?

@pfrazee pfrazee added the intl Internationalization label Jun 5, 2024
@marcomaroni-github
Copy link
Contributor Author

Is this one good to go?

Is this one good to go?

@pfrazee for me yes!

@pfrazee
Copy link
Collaborator

pfrazee commented Jun 5, 2024

Sorry did you intend to close this PR?

@marcomaroni-github
Copy link
Contributor Author

marcomaroni-github commented Jun 6, 2024

Sorry did you intend to close this PR?

No, I'm sorry, I made a mistake, in reporting other changes I closed this PR by mistake, but I just wanted to realign my fork. I would like to merge it.
I have opened an other PR #4374

@pfrazee
Copy link
Collaborator

pfrazee commented Jun 6, 2024

Cool no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intl Internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants