remove resolution from post thread #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nit completely remove did cache lookup move cache check for did to `usePostThreadQuery` remove resolution from post thread
|
Your Render PR Server URL is https://social-app-pr-4297.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpco1jv79t8c738p5i80. |
|
|
Placeholders regressed. plc.mov |
gaearon
reviewed
May 31, 2024
| } else if ( | ||
| !isDid && | ||
| quotedPost?.author.handle === atUri.host && | ||
| quotedPost.uri.endsWith(atUri.rkey) |
There was a problem hiding this comment.
This feels complicated. Ok but wondering if there are easier ways. I do think we need to pull this into a utility though cause the copy pasta is not obvious.
There was a problem hiding this comment.
Let's at least extract isSamePostUri or something
gaearon
requested changes
May 31, 2024
|
@gaearon can you check now if placeholders work? I can't repro the spinner even off the first commit and still can't, so not sure what happened there? Left a video on Slack. |
gaearon
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In the continuous effort to remove waterfalls, we can now remove these requests from
getPostThread. To do so however, we need to do a little bit of reworking on how we pull already-loaded posts from the cache.Currently we load the posts from the cache just based off of their URI. However, since we now are not going to have the resolved URI, we instead need to check both the handle and the rkey instead in our various
findAllPostsInQueryDatafunctions. This is a pretty straight forward change, though it adds a little extra logic.Test Plan
Note in the debugger that there are no more requests for DID resolutions when opening a post on a fresh load. Also note that whenever you open a post from these areas, there is no spinner: