-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent rich-formatting paste #4327
Prevent rich-formatting paste #4327
Conversation
Fix works for me, just need verification from others, easiest way to test is to have a fresh copy of Edge on Windows, and copy any links, like from the address bar. |
would be good to verify that the fix works, then we can pull it in. |
It seems to partially resolve the issue, but the link preview is not working (I'm not sure if this is the expected behavior). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some little note while reviewing your diff
I'll take another look tomorrow to see if there's anything that can be done, don't want to resort to detecting links and snipping the rest of it off |
I wonder how Twitter/Upwork does it. Maybe someone could look into that and then use either of their methods. |
Looks like this is happening because |
@auroursa Can you verify this again? I've confirmed that it works as it should on my end. |
@mary-ext Yeah it works very well for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't test Edge but this does result in more sensible paste output on macOS when pasting HTML from random places, let's give this a try.
Fixes #1321
Fixes #3032
Fixes #4301
We don't actually support rich WYSIWYG formatting in the composer, check if what's being pasted is one, and retrieve a plain-text version of it. This won't interfere with pasting HTML files (even though that's not supported either) as pasted files only have
Files
in the types array.