Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native formSheet for GIF select on iOS #4328

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Jun 3, 2024

Keeps existing ALF dialog for other platforms, just forks for iOS to provide a more native experience

Simulator.Screen.Recording.-.iPhone.15.-.2024-06-03.at.10.45.48.mp4

Test plan

Make sure there's no regressions

  • Selecting GIFs
  • Searching
  • Search errors
  • Other errors (error boundary stuff)

Copy link

render bot commented Jun 3, 2024

Copy link

github-actions bot commented Jun 3, 2024

Old size New size Diff
7.38 MB 7.38 MB -24 B (-0.00%)

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the duplication is a bit annoying and we can factor more shared stuff out but seems fine for now, let's see if it turns out a pita or not

@gaearon gaearon merged commit da96fb1 into main Jun 4, 2024
6 checks passed
@gaearon gaearon deleted the samuel/native-gif-select branch June 4, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants