Composer - replace threadgate modal with alf dialog

[mozzius]

iOS default	iOS with selections	Web

[render]

Your Render PR Server URL is https://social-app-pr-4329.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cpeok4i0si5c7390q780.

[github-actions]

Old size	New size	Diff
6.47 MB	6.47 MB	-370 B (-0.01%)

---

[gaearon]

Pressing Escape now tries to dismiss both dialogs (previously it was ignored). We need to fix this to only dismiss the inner one (like with GIF picker).

[gaearon]

also getting this weird spinner

[mozzius]

That's it loading your lists, maybe we should change the layout so that it's less janky

[gaearon]

nah, it never loads. just stuck like this. there also no new network requests.

on main, there's no spinner.

[gaearon]

• need to fix Escape handling
• distinguish no lists vs loading lists

[gaearon]

The height is jumping when changing selection, probably due to borders appearing and disappearing:

height.mov

It would be good to stabilize those.

Also, I'm not a big fan of using the same color for selection and the primary action:

Let's do a pass over these before getting it in.

[pfrazee]

Updated the buttons

one	two

[pfrazee]

@gaearon Interesting, is that 2-states solution preferable to using an effect?

[gaearon]

yeah, it avoids a "roundtrip", see here https://react.dev/reference/react/useState#storing-information-from-previous-renders:

This pattern can be hard to understand and is usually best avoided. However, it’s better than updating state in an effect. When you call the set function during render, React will re-render that component immediately after your component exits with a return statement, and before rendering the children. This way, children don’t need to render twice. The rest of your component function will still execute (and the result will be thrown away). If your condition is below all the Hook calls, you may add an early return; to restart rendering earlier.

however i think i'll actually move the state down so that it gets torn down on dialog close

[pfrazee]

Excellent work @mozzius @gaearon