Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few border nits #4349

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Fix a few border nits #4349

merged 5 commits into from
Jun 4, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Jun 4, 2024

Fixes:

  • Notifications header on tablet taking full width
  • Notifications loading state double border
  • Edit feeds harline

@render Render
Copy link

render bot commented Jun 4, 2024

Your Render PR Server URL is https://social-app-pr-4349.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cpfjgjdds78s73e9hon0.

haileyok
haileyok commented Jun 4, 2024
View reviewed changes
src/view/screens/SavedFeeds.tsx
showMinimalPlaceholder
showSaveBtn={!isPinned}
hideTopBorder={true}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other styles here add a border, so we'll just turn it off for all of the FeedSourceCards in this list.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

Old size New size Diff
7.4 MB 7.4 MB 29 B (0.00%)

@gaearon gaearon merged commit 9f00152 into main Jun 4, 2024
6 checks passed
@gaearon gaearon deleted the hailey/feed-edit-lines branch June 4, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyok @gaearon