use a timeout to focus the composer input #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4370.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpfssn5ds78s73ea5ogg. |
|
gaearon
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With the native modal, the input gets focused automatically still, but the keyboard does not present. This occurs both on-device and on an emulator. This is a small hack - one that we've had to use in other modals in the app - to focus the input slightly after the modal presents itself.
Test Plan
With a physical device, test that this properly shows the keyboard after opening. I tested lower intervals, and anything over 50ms worked every time for me, but 100ms feels just a little safer and does not affect anything visually or feel sluggish (since the animation is still ongoing anyway).