Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to search posts via profile dropdown #4373

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oracularhades
Copy link
Contributor

Description: I've been using search tags to get posts from users, usually finding posts from 6 months ago that are going around in my head. I've found some usernames are long and annoying to type, or I can just never remember them (I cannot for the life of me remember Paul's "pfrazee.com" username [paul ur awesome, I'm just bad at some names]). Usernames have no autocomplete in the search-bar when using search tags. This makes it nice and easy.

You'll notice I've made another "<Menu.Group>", this is because otherwise users can't see the button when viewing their own account, or it's above the divider when logged in (if using the menu.group share is in). It's not visible when logged out because menu.group #2 and #3 are both under an "isSession" condition. I could have added it separately, but it would have made the code slightly harder to read, when there really isn't a use case for showing the button when logged out.

Limitations:

  • "Search posts" is not translated.
  • I have not tested this on mobile.
Screenshot 2024-06-05 at 3 46 07 PM
github-search-posts-button.mp4

🦋

Thanks,
Josh

@oracularhades
Copy link
Contributor Author

Update. I have changed the position of the menu item, because before I didn't check what it looked like on someone else's profile (I'm very tired and it went over my head lol). It looked absurdly jarring before.

It could be nicer if it was in the middle of the other buttons, but that requires splitting the menu block and condition (so that someone can see it on their account), which I don't think is worth it unless the design team isn't happy with this.

Before: (jarring)
Screenshot 2024-06-05 at 4 07 42 PM

After:
Screenshot 2024-06-05 at 4 09 08 PM

Screenshot 2024-06-05 at 4 13 02 PM

@surfdude29
Copy link
Contributor

This would fix #2683 and #2684, thanks! 🙏

Copy link

@lucidillusions lucidillusions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants