Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve thread loading #4402

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Improve thread loading #4402

merged 3 commits into from
Jun 11, 2024

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Jun 6, 2024

Ignore the first commit. The second commit took a different approach:

  • Increase depth to 10
  • Replace the last post in a self-thread with a "Continue thread..." link

Here's a screenshot with the depth decreased to show the behavior:

image

@render Render
Copy link

render bot commented Jun 6, 2024

Your Render PR Server URL is https://social-app-pr-4402.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cph42mun7f5s73abc2ng.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024 •
edited
Loading

Old size New size Diff
7.39 MB 7.39 MB 1.93 KB (0.03%)

@pfrazee
Copy link
Collaborator Author

pfrazee commented Jun 7, 2024

Per Eric's feedback, stacked avis

CleanShot 2024-06-06 at 17 22 19@2x
CleanShot 2024-06-06 at 17 22 48@2x

@pfrazee
Copy link
Collaborator Author

pfrazee commented Jun 11, 2024

Alright I'm merging this sucker

@pfrazee pfrazee merged commit 46e12c6 into main Jun 11, 2024
6 checks passed
@pfrazee pfrazee deleted the paul/thread-loading branch June 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pfrazee