-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to work around a crash in RN internals #4426
Conversation
Your Render PR Server URL is https://social-app-pr-4426.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cphs8f6g1b2c73cb2hig. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, lets try it as long as CI runs
QQ @gaearon: are you folks building React Native Android from source? (see https://reactnative.dev/contributing/how-to-build-from-source). If not, this change will be ignored as the touched |
Hmm! We're just using Expo. But I thought in the past that these overrides worked... (cc @haileyok to confirm) |
Is just the Android code precompiled? |
hmm. we've definitely been able to patch for iOS (we have two load bearing patches for ios right now), don't know if we have patched for android before though! would be fairly easy to test if we want by throwing somewhere and seeing if things break. |
Yes the Android code is precompiled, the iOS one is not. So unless you turn on build from source on Android, the patches are ignored. |
Fascinating — thanks for the heads-up. |
Work around facebook/react-native#44842.
I don't have a way to verify whether this works. It would at least be nice to trigger this codepath somehow and verify it runs like before in the common case. That said, the change itself is a trivial change and maybe we can just get it in and try it.