register the push token after request has been approved on android #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4481.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpk7l9qcn0vc738bmrk0. |
|
This reverts commit efac398.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Temporary adjustment for now until we can mark messages read on the server and update the count. This will just decrement the badge count by the number of unread messages in the conversation when you open it.
Far from perfect, but given we're going to actually fix this in earnest in the nearish future, let's just make the badge clear for now and avoid digging too deeply at something that could cause more breaks.
I'm also adding one more fallback for push notification registration given the current expo bug. It shouldn't result in two push notification token registrations, but if it does that's fine too. Better to ensure their token registered right after onboarding.
Test Plan