use granular permission of for media perm request #4609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4609.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cps008jqf0us73ee259g. |
|
gaearon
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
See https://docs.expo.dev/versions/latest/sdk/media-library/#medialibrarygetpermissionsasyncwriteonly-granularpermissions
We should be setting a granular permission of
photoas the only thing we request. Otherwise, the default is to request access to all media types, which results in the weird "double prompt" we see now on Android.We'll have to adjust this for video of course once we add that - though we should make sure to request only
videowhen we do to prevent this double dialog again.Test Plan
Reinstall the Android app with a build of this one. You should still get a permission request for photos but you should not get a request for audio and video.