Wait for preferences before showing suggested feeds #4618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
useSavedFeeds
query needs the user's preferences to be loaded first. Generally a user's preferences should be loaded already and cached before we enter the wizard, but its possible for them to be invalidated when we enter. If they are invalidated, they will get refetched inside ofuseSavedFeeds
.While fetching preferences, the
useQuery
inuseSavedFeeds
is disabled. This means thatisLoading
will be false for a moment - so just checkingisLoadingSavedFeeds
will not always work. Instead, we want to look atisFetchedAfterMount
.Test Plan
You can add a test promise as shown in the video below and remove
staleTime: Infinity
.Before
Screen.Recording.2024-06-24.at.2.16.33.PM.mov
After
Screen.Recording.2024-06-24.at.2.17.24.PM.mov