Fix footer messages in starter pack wizard #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you pls separate the functional change and the translation into separate PRs? Also a screenshot of before/after would be very helpful. Thanks. |
|
The problem with coupling a functional change to a translation change is that it's more difficult to tell how to modify other translations, and kind of leaves us in an inconsistent state. Ideally we'd just make the fix alone without invalidating translations if possible. |
gaearon
approved these changes
Jun 26, 2024
|
verified English, French, Japanese updates.mov |
|
Ah sorry to mix functional changes and translation updates. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At footer messages in starter pack wizard, when selected two feeds, first of selected items are displayed as 'You', not the feed's name. This PR fixes this problem.
This PR also contains companion Japanese message updates.