Handle pressing all go.bsky.app links in-app w/ resolution #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4680.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpurqahu0jms73eu8tig. |
|
haileyok
commented
Jun 27, 2024
src/Navigation.tsx
Outdated
Comment on lines
330
to
334
| <Stack.Screen | ||
| name="StarterPackShort" | ||
| getComponent={() => StarterPackScreenShort} | ||
| options={{title: title(msg`Starter Pack`), requireAuth: true}} | ||
| /> |
There was a problem hiding this comment.
A new route that accepts a code parameter rather than name and rkey
haileyok
force-pushed
the
hailey/json-resolution-short-links
branch
from
55457c1 to
3385238
Compare
haileyok
commented
Jun 28, 2024
Comment on lines
-115
to
-117
| setActiveStarterPack({ | ||
| uri: starterPack.uri, | ||
| }) |
There was a problem hiding this comment.
Just removing this since it is unneeded. No change in functionality.
gaearon
approved these changes
Jun 28, 2024
|
Retested signup flow w/ a starter pack, works good. This is a little funky as noted but is mostly a corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to be able to resolve any short links in the app, even if they don't get resolved while posting. This is a little challenging because we have to reach out to
go.bsky.appfirst. I added JSON response support in #4671, which we can now use to perform resolution when landing on these.How
bsky.appbut we don't checkgo.bsky.appwhich we add here.StarterPackScreenShortrouteThe nice thing here is this is extensible to other schemes whenever we want to. For example, post short links - which we are less worried about being very short - could use
/p/123456and we could create a resolve query for those types of links.Test Plan