Handle pushing to starterpack screen when unauthed #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4692.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpv2gorgbbvc73a2tskg. |
haileyok
changed the title
|
haileyok
force-pushed
the
hailey/signed-out-sp-push
branch
from
ec882cb to
72d21a1
Compare
haileyok
force-pushed
the
hailey/signed-out-sp-push
branch
from
80c6628 to
ccffd42
Compare
gaearon
reviewed
Jun 28, 2024
gaearon
reviewed
Jun 28, 2024
gaearon
reviewed
Jun 28, 2024
| const {_} = useLingui() | ||
| const {state, dispatch} = useSignupContext() | ||
|
|
||
| useEffect(() => { | ||
| LayoutAnimation.configureNext(LayoutAnimation.Presets.easeInEaseOut) |
There was a problem hiding this comment.
This is kind of a race condition, effects have no well-defined lifetime in RN right now so this call may align with some different paint. Can we move this closer to the setstate we actually want to animate?
There was a problem hiding this comment.
going to leave for now and see per conversation.
gaearon
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.