Don't follow self, blocks or mute when following all; don't show blocks in list #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4715.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cq1iro56l47c73bg0p90. |
|
haileyok
changed the title
gaearon
reviewed
Jul 1, 2024
| .filter(p => !p.associated?.labeler) | ||
| .filter( | ||
| p => | ||
| !p.viewer?.blockedBy && !p.viewer?.blocking && !p.associated?.labeler, |
There was a problem hiding this comment.
is this logic copypaste from somewhere? any reference points?
There was a problem hiding this comment.
idt so (in either this case or the one below). this is the one weird place where we actually don't filter the blocks out on the server because of how other lists work. we could extract it to a function if we want to though even if it doesn't get used much/ever again.
There was a problem hiding this comment.
(probably something like isBlockedOrMuted()?)
There was a problem hiding this comment.
did that, though made them two separate things (blocked vs muted)
| .filter(li => !li.subject.viewer?.following) | ||
| .filter( | ||
| li => | ||
| li.subject.did !== currentAccount?.did && |
gaearon
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Simple, just don't follow yourself (still love that you can do this lol) whenever pressing Follow All in a starter pack. You also shouldn't follow people you have muted or are blocking/blocked by.
Similarly, don't show blocks in the list of profiles - lists actually return blocked accounts (behavior of mute lists) so we need to filter here.
Test Plan
Follow all on a starter pack, see that you no longer follow yourself or blocks/mutes. Also see that blocked accounts don't show up in the list of profiles.