Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bskyweb: add robots disallow and 'canonical' config flags #4760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bnewbold
Copy link
Contributor

@bnewbold bnewbold commented Jul 9, 2024

NOTE: it is critical to enable the "canonical" flag for our prod deployment before merging/deploying this branch.

Adds two config/envvar flags:

  • one to allow swapping in a blank "Disallow: *" robots.txt to prevent crawling (eg, in dev/staging/informal deployments)
  • another to only serve some endpoints in the "canonical" deployment (eg, bsky.app)

Normally we might try to detect what "environment" we are in and change these behaviors based on that, but we have kind of a sprawling menagerie of environments, and folks also might be forking this repo for their own use, so made these more granular flags. Open to changing path and doing this the traditional ENVIRONMENT variable way though.

@bnewbold bnewbold requested review from ericvolp12 and devinivy July 9, 2024 21:56
Copy link

render bot commented Jul 9, 2024

Copy link

github-actions bot commented Jul 9, 2024

Old size New size Diff
6.61 MB 6.61 MB 0 B (0.00%)

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but i don't go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants