Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint native files #4768

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Lint native files #4768

merged 7 commits into from
Jul 12, 2024

Conversation

haileyok
Copy link
Contributor

Why

Finally got tired of Xcode's non-existent formatting and Android Studio's far-too-lax formatting rules.

Test Plan

It builds. No real changes aside from formatting.

Copy link

render bot commented Jul 11, 2024

Copy link

github-actions bot commented Jul 11, 2024

The Pull Request introduced fingerprint changes against the base commit:

Fingerprint diff
[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"7cdcd13c241fc44ede22cbe4741e636c17512eda"},{"type":"dir","filePath":"modules/expo-background-notification-handler/android","reasons":["expoAutolinkingAndroid"],"hash":"52d657fdfccb75f93bb1433d0f694191a71c1f49"},{"type":"dir","filePath":"modules/expo-background-notification-handler/ios","reasons":["expoAutolinkingIos"],"hash":"1181ce5eedbeeccadba932a2d0734829baca63ec"},{"type":"dir","filePath":"modules/expo-bluesky-gif-view/android","reasons":["expoAutolinkingAndroid"],"hash":"4d804a7f90307d7376e91e8ce6b8cf0b33ce3132"},{"type":"dir","filePath":"modules/expo-bluesky-gif-view/ios","reasons":["expoAutolinkingIos"],"hash":"b77c900537205bc416c846fa7b2fa5d4a3d16621"},{"type":"dir","filePath":"modules/expo-bluesky-swiss-army/android","reasons":["expoAutolinkingAndroid"],"hash":"76921585db45d1ac1314abb74a67a6d24ca3c22b"},{"type":"dir","filePath":"modules/expo-receive-android-intents/android","reasons":["expoAutolinkingAndroid"],"hash":"4787a3cad54f41a304f8ff8ddc31b5799455a5ed"},{"type":"dir","filePath":"modules/expo-scroll-forwarder/ios","reasons":["expoAutolinkingIos"],"hash":"5622c8a603984fab86f20bddd229d210c1bf7c16"},{"type":"contents","id":"packageJson:scripts","contents":"{\"prepare\":\"is-ci || husky install\",\"postinstall\":\"patch-package && yarn intl:compile\",\"prebuild\":\"expo prebuild --clean\",\"android\":\"expo run:android\",\"ios\":\"expo run:ios\",\"web\":\"expo start --web\",\"use-build-number\":\"./scripts/useBuildNumberEnv.sh\",\"use-build-number-with-bump\":\"./scripts/useBuildNumberEnvWithBump.sh\",\"build-web\":\"expo export:web && node ./scripts/post-web-build.js && cp -v ./web-build/static/js/*.* ./bskyweb/static/js/ && cp -v ./web-build/static/media/*.png ./bskyweb/static/media/\",\"build-all\":\"yarn intl:build && yarn use-build-number-with-bump eas build --platform all\",\"build-ios\":\"yarn use-build-number-with-bump eas build -p ios\",\"build-android\":\"yarn use-build-number-with-bump eas build -p android\",\"build\":\"yarn use-build-number-with-bump eas build\",\"build-embed\":\"cd bskyembed && yarn build && yarn build-snippet && cd .. && node ./scripts/post-embed-build.js\",\"start\":\"expo start --dev-client\",\"start:prod\":\"expo start --dev-client --no-dev --minify\",\"clean-cache\":\"rm -rf node_modules/.cache/babel-loader/*\",\"test\":\"NODE_ENV=test jest --forceExit --testTimeout=20000 --bail\",\"test-watch\":\"NODE_ENV=test jest --watchAll\",\"test-ci\":\"NODE_ENV=test jest --ci --forceExit --reporters=default --reporters=jest-junit\",\"test-coverage\":\"NODE_ENV=test jest --coverage\",\"lint\":\"eslint --cache --ext .js,.jsx,.ts,.tsx src\",\"typecheck\":\"tsc --project ./tsconfig.check.json\",\"e2e:mock-server\":\"./jest/dev-infra/with-test-redis-and-db.sh ts-node --project tsconfig.e2e.json __e2e__/mock-server.ts\",\"e2e:metro\":\"EXPO_PUBLIC_ENV=e2e NODE_ENV=test RN_SRC_EXT=e2e.ts,e2e.tsx expo run:ios\",\"e2e:run\":\"maestro test __e2e__\",\"perf:test\":\"NODE_ENV=test maestro test\",\"perf:test:run\":\"NODE_ENV=test maestro test __e2e__/perf-test.yml\",\"perf:test:measure\":\"NODE_ENV=test flashlight test --bundleId xyz.blueskyweb.app --testCommand \\\"yarn perf:test\\\" --duration 150000 --resultsFilePath .perf/results.json\",\"perf:test:results\":\"NODE_ENV=test flashlight report .perf/results.json\",\"perf:measure\":\"NODE_ENV=test flashlight measure\",\"intl:build\":\"yarn intl:extract && yarn intl:compile\",\"intl:extract\":\"lingui extract\",\"intl:compile\":\"lingui compile\",\"nuke\":\"rm -rf ./node_modules && rm -rf ./ios && rm -rf ./android\",\"update-extensions\":\"bash scripts/updateExtensions.sh\",\"export\":\"npx expo export\",\"make-deploy-bundle\":\"bash scripts/bundleUpdate.sh\",\"generate-webpack-stats-file\":\"EXPO_PUBLIC_GENERATE_STATS=1 yarn build-web\",\"open-analyzer\":\"EXPO_PUBLIC_OPEN_ANALYZER=1 yarn build-web\"}","reasons":["packageJson:scripts"],"hash":"525f969feffc519224a45ac1e92c40c221a1eceb"}]

Generated by PR labeler 🤖

Copy link

github-actions bot commented Jul 11, 2024

Old size New size Diff
6.61 MB 6.62 MB 923 B (0.01%)

@@ -29,6 +29,8 @@
"test-ci": "NODE_ENV=test jest --ci --forceExit --reporters=default --reporters=jest-junit",
"test-coverage": "NODE_ENV=test jest --coverage",
"lint": "eslint --cache --ext .js,.jsx,.ts,.tsx src",
"lint-native": "swiftlint ./modules && ktlint ./modules",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be added to the CI run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was going to, but it wasn't immediately obvious how to get it working on ubuntu (saw something about docker 😦)

would like to do that though at some point, idk if we'd need to use a macos runner to get it to run or not though, so i'll figure it out later. isn't extremely vital now since this only deals with formatting anyway and errors can't cause problems.

@haileyok haileyok merged commit 2397104 into main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants