-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priority notifications #4798
Priority notifications #4798
Conversation
Your Render PR Server URL is https://social-app-pr-4798.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqc49f3gbbvc73bdnlb0. |
|
65e5adc
to
dd7449b
Compare
dd7449b
to
7451a5a
Compare
Left two notes, but with a minimal test this works well. I'm still concerned about one thing especially after using this but unrelated to the PR, I'll flag it in Slack. |
Co-authored-by: Hailey <me@haileyok.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested a bunch of different states
- Intermitent network
- Going back before preference updates
- Slow network and spam change
Things seem really good here. Weighed pros/cons of that mutation, and for now this seems okay, since it's already a little bizarre how we're getting the preference. I think we will want to start returning a preference object whenever we add more preferences here (like granular filters).
Gonna have to build for TF to test since OTA is borked. Great work @mozzius!!! 🥳
Adds a new page,
/notifications/settings
with a toggle to turn priority notifications on.Backend is not yet deployed at time of writingIt's ready to go!Note on behaviour - we get what the current priority setting is from
listNotifications
. If we call this immediately after, I was running into read-after-write issues, so it attempts it a few times before giving feedback to the user on whether it has succeeded or not. It disables the input while waiting.It shows a spinner while waiting for the initial value, if it's not already cached (which it should be 9/10 times, since it reuses the query from the main page and you're likely coming from that page)