Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make some settings screens scrollable for accessibility #4819

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

haileyok
Copy link
Contributor

Why

Just using CenteredView on native causes some screens - like DM settings - to not allow the user to view all the options if they are using font scaling. Make them scrollviews instead.

Test Plan

Test that the views are the same, just scrollable now.

Copy link

render bot commented Jul 24, 2024

Copy link

Old size New size Diff
6.63 MB 6.63 MB 54 B (0.00%)

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfrazee pfrazee merged commit 11f2415 into main Jul 24, 2024
6 checks passed
@pfrazee pfrazee deleted the hailey/scrollview-settingfs branch July 24, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants