Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Show replies in context of their threads #4835

Closed
wants to merge 8 commits into from
Closed

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jul 25, 2024

This moves replies in feeds to work much more similarly to Twitter.

Not ready for review yet.

What it looks like

  • Replies never show up in isolation — a reply is always seen in context of its root thread
  • Slices are deduped by thread — with default settings, a friend reply essentially "bumps" a thread
  • Threads never get torn apart, whether due to pagination or different author
  • For long convos, you see root + last two items, which gives you better context than 1,2...N

TODO

  • Proof of concept
  • Address TODOs in code
  • Handle blocks (for all levels), not found
  • Handle Posts, Replies tabs
  • Check feeds, lists
  • Check self-threads
  • Check how deduping interacts with self-reposts
  • Double-check filtering still makes sense
  • Simplify data structures
  • Fix the "self-reply to a non-follow" problem
  • Consider dropping reply settings
new_thread.mov

What it fixes

Torn replies like this will no longer happen:

Screenshot 2024-07-25 at 21 17 45
Screenshot 2024-07-25 at 21 18 00

Replies without context like this will no longer happen:

Screenshot 2024-07-25 at 21 14 49
Screenshot 2024-07-25 at 21 15 00

Copy link

render bot commented Jul 25, 2024

@gaearon gaearon mentioned this pull request Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Old size New size Diff
7.01 MB 7.01 MB -736 B (-0.01%)

@gaearon gaearon force-pushed the feedsliceitem-2 branch 4 times, most recently from 47d862e to 13981bb Compare July 25, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants