Add twemoji #4862
Draft
Add twemoji #4862
+96
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4862.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqlarr0gph6c73ft8t3g. |
|
|
There is also this fork of Twemoji. https://github.com/jdecked/twemoji |
|
Ah, thanks, that looks a little more up-to-date |
|
jdecked's twemoji fork is the current fork everyone using twemoji uses, it is consistently updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1258, #2426
Uses @discordapp/twemoji (discord's fork, I think the original is dead)
Uses jsdelivr CDN, but I'm guessing we'd want to host this ourselves - leaving in draft until we get the backend resource to do that
Implementation:
Made a twemoji component which takes a string, and if it's got emoji in it, splits the graphemes and replaces them with images. Scattered it all around the RichText component, wherever it's rendering a string