Universal back button component #4903
Open
+139
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4903.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqqlfddumphs739vq250. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda random but I hate our back chevron. The tap target is too small and it generally looks a bit off. There is also a lot of duplicated code re-creating this back button.
This replaces most instances with a new
<BackButton>component. On native, it uses platform-native back buttons from@react-nativgation/elements, tweaked to match the size and colour of our existing button.Current:
New (iOS)
New (Android)
Test plan
ViewHeader,SimpleViewHeader, the DMs header, the user list header etc