[Video] More tweaks to AVAudioSession
options
#4910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Upon doing some documentation digging, it looks like we might actually want to be tweaking the category itself from
ambient
toplayback
depending on what state we are in.How
First, it looks like we want to take our app out of the default state, which is
soloAmbient
. This is described asAnd the
ambient
category is described asFinally, whenever we want for audio to take over - without background audio - we should switch to
playback
. We want this because video audio should play whenever the user enables it - regardless of their silent mode.Note that this might have implications as described here on what happens when the app transitions to the background, however, I believe that
AVPlayer
should handle those cases. We will need to see what happens on device.I don't believe that this will account for restarting of background audio whenever the user exits full screen for a video. I'll investigate that with a separate PR.
Test Plan
More changes that are hard to test in simulator here. We should see what happens whenever the TestFlight app updates. I expect we will want to tweak more.