-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Video] Performance tweaks for Android #4997
[Video] Performance tweaks for Android #4997
Conversation
Your Render PR Server URL is https://social-app-pr-4997.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cr6foejv2p9s73ck09d0. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although we do need to get the currentTime indicator back at some point
// const interval = setInterval(() => { | ||
// // duration gets reset to 0 on loop | ||
// if (player.duration) setDuration(Math.floor(player.duration)) | ||
// setCurrentTime(Math.floor(player.currentTime)) | ||
// | ||
// // how often should we update the time? | ||
// // 1000 gets out of sync with the video time | ||
// }, 250) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea what we need to do to uncomment this? :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I have a plan to fix this today.
built on #5003
Why