-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some Portuguese (PT-BR) translation #5057
Conversation
@fabiohcnobre I went ahead and ran them. Appreciate all of this! Also thanks @pietrofxq and @bybruno!! 💙 |
I need one reviewer |
@joicepassos Thanks for the tips. I have already updated the file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked everything over and it looks good to me. No problems.
Thanks @joicepassos! @fabiohcnobre Looks like you've had a few people look over these now, feeling like they are ready for merge? (Can always get updated again later too!) |
@haileyok Yes thanks |
@haileyok Yes |
Okay, I have something that I need to deploy this evening, so will get this in as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 💙
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fabiohcnobre I left you a few comments but the most important seems to be this one #5057 (comment)
Thanks @ederrf! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending recommended changes
Additionally, if you don't mind updating these lines! https://github.com/fabiohcnobre/social-app/blob/main/src/locale/locales/pt-BR/messages.po#L12-L13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you everyone!
(cherry picked from commit f3f7dfc)
Can't vouch for top quality here but better than what we had. Hopefully can get cleaned up soon.