Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Portuguese (PT-BR) translation #5057

Merged
merged 16 commits into from
Sep 2, 2024
Merged

Add some Portuguese (PT-BR) translation #5057

merged 16 commits into from
Sep 2, 2024

Conversation

fabiohcnobre
Copy link
Contributor

Can't vouch for top quality here but better than what we had. Hopefully can get cleaned up soon.

@fabiohcnobre fabiohcnobre marked this pull request as draft September 1, 2024 00:15
@fabiohcnobre fabiohcnobre marked this pull request as ready for review September 1, 2024 00:15
@str4d
Copy link

str4d commented Sep 1, 2024

#5057 (comment)

@haileyok
Copy link
Contributor

haileyok commented Sep 1, 2024

@fabiohcnobre I went ahead and ran them. Appreciate all of this! Also thanks @pietrofxq and @bybruno!! 💙

@fabiohcnobre
Copy link
Contributor Author

I need one reviewer

@fabiohcnobre
Copy link
Contributor Author

@joicepassos Thanks for the tips. I have already updated the file.

Copy link

@joicepassos joicepassos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked everything over and it looks good to me. No problems.

@haileyok
Copy link
Contributor

haileyok commented Sep 2, 2024

Thanks @joicepassos! @fabiohcnobre Looks like you've had a few people look over these now, feeling like they are ready for merge? (Can always get updated again later too!)

@fabiohcnobre
Copy link
Contributor Author

@haileyok Yes thanks

@joicepassos
Copy link

@haileyok Yes

@haileyok
Copy link
Contributor

haileyok commented Sep 2, 2024

Okay, I have something that I need to deploy this evening, so will get this in as well. Thanks!

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💙

Copy link

@ederrf ederrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fabiohcnobre I left you a few comments but the most important seems to be this one #5057 (comment)

@haileyok
Copy link
Contributor

haileyok commented Sep 2, 2024

Thanks @ederrf!

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending recommended changes

@haileyok
Copy link
Contributor

haileyok commented Sep 2, 2024

Additionally, if you don't mind updating these lines!

https://github.com/fabiohcnobre/social-app/blob/main/src/locale/locales/pt-BR/messages.po#L12-L13

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you everyone!

@haileyok haileyok merged commit f3f7dfc into bluesky-social:main Sep 2, 2024
6 checks passed
@fabiohcnobre
Copy link
Contributor Author

@ederrf I made a new commit with the changes. Thanks
@haileyok Also in the commit above adjust the language team line.

haileyok pushed a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants