-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul IT locale #5069
Overhaul IT locale #5069
Conversation
Pinging @marcomaroni-github as he has been working on updating the Italian localization so maybe you can combine efforts? |
Sure, I'm available. I also submitted two PRs months ago with updated translations, but I'm still waiting. |
Amazing! Maybe we could talk somewhere like Discord to coordinate things? |
We can start following each other on Blusky, then through DMs we will evaluate the best tool... |
@surfdude29 how do we proceed operationally, do I comment on each of his changes with an ok or by reporting translation problems? |
@marcomaroni-github hey! just to let you know, the reason this hasn't gotten merged is because there's something going on with how you're pushing the changes 🤔 #4592. it's showing as having no changes in the PR, so there's nothing to merge in 😢 looks like this pr here is good though, so if you want to go ahead and just review @arukamiyun's work we can definitely get this merged in! sorry for the delay |
No prioblem, I reviwed this PR and it'ok! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big update, fantastic work @arukamiyun! 💫
I don't speak Italian unfortunately, but I noticed a few pretty minor things (some with the help of DeepL 😅) and I've made a few suggestions which I hope are helpful.
Hopefully I'm gonna answer this comment correctly this time, thanks for the suggestions! As for the "Risposta a un post bloccato", it's actually as I originally edited, "Rispondi a un post bloccato", so I didn't fix those lines. Thank you so much again! |
You're welcome, I'm glad my suggestions were helpful :) And well done again on the great job you did 🫡 As a final step, you might want to tag Paul to let him know that this is ready to go, as I think he might be cutting a release soon 👀 |
Thanks so much again! @pfrazee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! Thanks all!
Some things are still missing, but I tried to overhaul the entire thing.