Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Video] Upload errors and UI improvements #5092

Merged
merged 5 commits into from
Sep 3, 2024
Merged

[Video] Upload errors and UI improvements #5092

merged 5 commits into from
Sep 3, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Sep 2, 2024

  • Surface errors in UI
  • Check mime types for disallowed types
  • Try and show server errors where available
  • Try and clean up reducer (replace SetStatus with transitions between states)
  • Clean up upload UI
  • Use done status rather than idle

Screenshot 2024-09-02 at 21 21 50
Screenshot 2024-09-02 at 21 21 30

@render Render
Copy link

render bot commented Sep 2, 2024

Your Render PR Server URL is https://social-app-pr-5092.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-crb1toij1k6c738ibn80.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024 •
edited
Loading

Old size New size Diff
7.09 MB 7.09 MB 0 B (0.00%)

haileyok
haileyok approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to test, but code looks good.

src/state/queries/video/util.ts Outdated Show resolved Hide resolved
src/state/queries/video/video-upload.web.ts Outdated Show resolved Hide resolved
src/view/com/composer/Composer.tsx Show resolved Hide resolved
@haileyok
Copy link
Contributor

haileyok commented Sep 3, 2024

Tested uploads, seems good though didn't try each format.

Left a note in slack about missing .mov support which isn't great...

@mozzius mozzius merged commit 0e1de19 into main Sep 3, 2024
@mozzius mozzius deleted the samuel/upload-errors branch September 3, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyok haileyok haileyok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mozzius @haileyok