Maintain like state when navigating between screens #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-5095.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-crb3gk3v2p9s738a70dg. |
|
haileyok
force-pushed
the
hailey/persist-like-state
branch
from
d4be906 to
1b82c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We're using a
WeakMapright now for our post thread shadow, which is a bit annoying. The way we use it, we use aPostViewas the key for lookups, which is generally fine but causes problems when navigating between screens. For example:Screen.Recording.2024-09-02.at.3.09.09.PM.mov
This happens because the
PostViewthat we get in response togetPostThreadis not the same as thePostViewthat was seen in the feed.Test Plan
Since here we use just the post's URI as a key, we get the expected behavior of "keeping" the like whenever transition between screens
Screen.Recording.2024-09-02.at.3.11.30.PM.mov