[Video] Say No to Audio (Disable expo-video AudioSession management)
#5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-5101.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-crb8g5ggph6c73f8pfog. |
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"dir","filePath":"node_modules/expo-video/ios","reasons":["expoAutolinkingIos"],"hash":"6f72e030f58f0d304ca6bcf64549ea3de10392e7"},{"type":"dir","filePath":"patches","reasons":["patchPackage"],"hash":"889d6edebec570bf13443b7ca390d128c9cf0db1"}]Generated by PR labeler 🤖 |
|
haileyok
changed the title
expo-video AudioSession management)expo-video AudioSession management)
mozzius
approved these changes
Sep 3, 2024
mozzius
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We're managing
AudioSessionstate on our own throughPlatformInfo. This lets us decide what to do when we want to do it, rather than relying on Expo's hardcoded management.Test Plan
Test different ways of starting/stopping video audio playback while background audio is playing on iOS. Things shouldn't get borked, even between backgrounding and foregrounding the app.