fix [5015]: Accidentally deleting draft post when you mention an account #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeberryPi
reviewed
Sep 3, 2024
| React.useEffect(() => { | ||
| if (editor) { | ||
| const handleKeyDown = (event: KeyboardEvent) => { | ||
| if ((event.metaKey || event.ctrlKey) && event.code === 'ArrowLeft') { |
There was a problem hiding this comment.
in windows, the hotkey for navigating to the previous page on chrome is alt + ←, not ctrl + ←.
we should test if the bug is reproducible in windows and adjust the code accordingly.
There was a problem hiding this comment.
you're right! I don't have a windows machine nearby to test this, but the issue will very likely occur in that environment as well. i'll make the change.
LukeberryPi
reviewed
Sep 3, 2024
half144
commented
Sep 3, 2024
you can see the error in #5105 that pr take care of this |
LukeberryPi
reviewed
Sep 3, 2024
Co-authored-by: LukeberryPi <lukeberrypi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Accidentally deleting draft post when you mention an account #5105
This PR fixes the cursor movement functionality to the beginning of the line when the Cmd + ArrowLeft (or Ctrl + ArrowLeft) key combination is pressed. Previously, the behavior was not working as expected due to issues with setting the selection in the editor.
Screenshots:
364027282-bd9931a7-b71b-43c9-9403-3fe297a5676c.mov