Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Video] Tweak playback handling #5127

Merged
merged 2 commits into from
Sep 4, 2024
Merged

[Video] Tweak playback handling #5127

merged 2 commits into from
Sep 4, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Sep 3, 2024 •
edited
Loading

Why

Adjust the logic to start/stop playback whenever switching tabs.

Test Plan

  • Visit one tab, unmute a video
  • Switch to another tab. Audio should stop playing
  • Switch back to the tab, the video should resume playing but audio should be muted
Screen.Recording.2024-09-03.at.5.06.22.PM.mov

@render Render
Copy link

render bot commented Sep 3, 2024

Your Render PR Server URL is https://social-app-pr-5127.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-crbq5rrv2p9s738bq8q0.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Old size New size Diff
7.09 MB 7.09 MB 0 B (0.00%)

@haileyok haileyok marked this pull request as ready for review September 4, 2024 00:08
@haileyok haileyok requested a review from mozzius September 4, 2024 00:08
mozzius
mozzius approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking goooood

@haileyok haileyok merged commit 21e48bb into main Sep 4, 2024
6 checks passed
@haileyok haileyok deleted the hailey/tweak-playback-handling branch September 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzius mozzius mozzius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyok @mozzius