[Video] Add loading state to player #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-5149.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-crcbe0rtq21c73fjafp0. |
|
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"dir","filePath":"node_modules/expo-video/ios","reasons":["expoAutolinkingIos"],"hash":"83f39cea9de7cb277422ffc9ded938d167748016"},{"type":"dir","filePath":"patches","reasons":["patchPackage"],"hash":"efbf60dd34e99fd1232fe618391bf23dce5bbfa9"}]Generated by PR labeler 🤖 |
mozzius
approved these changes
Sep 4, 2024
| </ErrorBoundary> | ||
| </View> | ||
| ) | ||
| } | ||
|
|
||
| function Inner({embed}: Props) { |
There was a problem hiding this comment.
Could we possibly have a name other than Inner to disambiguate from VideoEmbedInner?
haileyok
force-pushed
the
hailey/loading-state
branch
from
0604783 to
062b6d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Adding loading state to the player, similar to what we do with JIFs.
Test Plan
TBD