Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video] Enter/exit animations for video in composer #5164

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Sep 5, 2024

Native only. Also fixes some layout jumping due to different margins between steps

The error appearing on cancel is fixed in #5163, so it'll be a lot smoother after that

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-05.at.14.18.05.mp4

Copy link

render bot commented Sep 5, 2024

Copy link

github-actions bot commented Sep 5, 2024

Old size New size Diff
7.09 MB 7.09 MB 0 B (0.00%)

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (didn't test but code is 👍 ). Only question is if it needs to be wrapped in a skipExiting config? I think it might look weird when the composer closes (at least on Android, where the modal doesn't slide away like on iOS). Could be wrong though.

@mozzius
Copy link
Member Author

mozzius commented Sep 5, 2024

Yeah no harm in doing a LayoutAnimationConfig, good shout

@mozzius mozzius merged commit 4e6b674 into main Sep 5, 2024
6 checks passed
@mozzius mozzius deleted the samuel/composer-animations branch September 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants