[Video] Mute behaviour & autoplay disabled improvements #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/autoplay-disabled-improvements - social-app PR #5295
Render
Destroyed
mozzius
commented
Sep 12, 2024
Comment on lines
+108
to
+116
| useEffect(() => { | ||
| function listener(newIsPlaying: boolean) { | ||
| setIsPlaying(newIsPlaying) | ||
| } | ||
| player.addListener('playingChange', listener) | ||
| return () => { | ||
| player.removeListener('playingChange', listener) | ||
| } | ||
| }, [player]) |
There was a problem hiding this comment.
We've had issues with player in useeffects before, is this one ok?
There was a problem hiding this comment.
🥳 (can update this after merging my fix or vice versa, but this effect should be okay in general from what i saw before...)
|
|
With these changes, will the play state (active vs. paused, muted vs. noisy) persist when toggling back + forth between the feed preview + the fullscreen video player? As shipped, 1.91 exhibits the following behavior:
Actual behavior:
Expected behavior:
|
|
Yeah it should be much more sane with autoplay disabled, will act more like web desktop |
|
okay lets try to get this into my pr... |
|
Merged in through rebases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things (all native)
The rationale behind change # 3 is that when autoplay is disabled, it acts a bit more like a traditional video player and thus would be nice to be able to make it stop playing
Test plan
Test all 3 changes individually. Make sure with autoplay enabled, there are no regressions other than the the persisted mute state change