[Video] use dynamic import for hls.js #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
hailey/dynamic-hljs - social-app PR #5429
Render
Destroyed
|
gaearon
reviewed
Sep 19, 2024
src/view/com/util/post-embeds/VideoEmbedInner/VideoEmbedInnerWeb.tsx
Outdated
Show resolved
Hide resolved
gaearon
requested changes
Sep 24, 2024
There was a problem hiding this comment.
- there's a race that needs to be fixed
- this is also a bit stale compared to main, and more refactoring would be needed on main before the same approach can be made to work here. i've tried doing it here so you can try to use this but i think we also need to adjust the
handleFragChangethere (and onmain), i'll make another ticket for that
src/view/com/util/post-embeds/VideoEmbedInner/VideoEmbedInnerWeb.tsx
Outdated
Show resolved
Hide resolved
arcalinea
temporarily deployed
to
hailey/dynamic-hljs - social-app PR #5429
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/dynamic-hljs - social-app PR #5429
Render
Destroyed
gaearon
approved these changes
Sep 25, 2024
gaearon
reviewed
Sep 25, 2024
| @@ -413,7 +416,7 @@ export function Controls({ | |||
| <View | |||
| pointerEvents="none" | |||
| style={[a.absolute, a.inset_0, a.justify_center, a.align_center]}> | |||
| {buffering && <Loader fill={t.palette.white} size="lg" />} | |||
| {showSpinner && <Loader fill={t.palette.white} size="lg" />} | |||
There was a problem hiding this comment.
should the above condition use showSpinner too instead of buffering? i have not tested visually closely
arcalinea
temporarily deployed
to
hailey/dynamic-hljs - social-app PR #5429
Render
Destroyed
|
Tested on the video feed w/ deployment, seems to be working good now. Appreciate you taking a look @gaearon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.