Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix German localisation of social proof #5451

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tamschi
Copy link

@Tamschi Tamschi commented Sep 23, 2024

The NaN and grammar were bothering me too much. Much like in English, the passive construction here implies dative case (which has indistinguishable genders and plurals of "andere(r)", conveniently enough).

That said, it's very unusual and pretty rough to use the number "1" in this position. In German, you would always use the indeterminate singular article here instead, which unfortunately is gendered between "einem" and "einer" even in dative.

The best way to fix this properly is most likely to avoid the "one other" case entirely here, i.e. you'd either list three users or (more likely in terms of screen space) write "Gefolgt von … und 2 anderen" in the three-known-followers case. I'm not sure how to implement this here.

This is not entirely correct, however, as it's not idiomatic at all to use the number "1" here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant