Allow profile header to overscroll #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/allow-overscroll - social-app PR #5457
Render
Destroyed
|
arcalinea
temporarily deployed
to
samuel/allow-overscroll - social-app PR #5457
Render
Destroyed
mozzius
commented
Sep 23, 2024
Comment on lines
-232
to
+249
| const headerTransform = useAnimatedStyle(() => ({ | ||
| transform: [ | ||
| { | ||
| translateY: Math.min(Math.min(scrollY.value, headerOnlyHeight) * -1, 0), | ||
| }, | ||
| ], | ||
| })) | ||
| const headerTransform = useAnimatedStyle(() => { | ||
| const translateY = Math.min(scrollY.value, headerOnlyHeight) * -1 | ||
| return { | ||
| transform: [ | ||
| { | ||
| translateY: allowHeaderOverScroll | ||
| ? translateY | ||
| : Math.min(translateY, 0), | ||
| }, | ||
| ], | ||
| } | ||
| }) |
There was a problem hiding this comment.
This is where the action happens, the rest is just prop drilling
mozzius
commented
Sep 23, 2024
| @@ -82,6 +83,7 @@ export const ProfileFeedSection = React.forwardRef< | |||
| onScrolledDownChange={setIsScrolledDown} | |||
| renderEmptyState={renderPostsEmpty} | |||
| headerOffset={headerHeight} | |||
| progressViewOffset={ios(0)} | |||
There was a problem hiding this comment.
this makes sure the spinner is at the top of the page, where it should be
gaearon
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
code seems ok to me but maybe let's not enable this yet (i.e. not set prop to true) until we get in the blurred stuff in as well? the behavior in this PR feels a bit weird to me.
or do you think this is decent as is? i guess it better handles profiles with tall bios than main?
|
I can easily feature flag it? |
mozzius
force-pushed
the
samuel/allow-overscroll
branch
from
e5abcd0 to
bdc0a73
Compare
arcalinea
temporarily deployed
to
samuel/allow-overscroll - social-app PR #5457
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the simple parts out of #2171
Adds
allowHeaderOverScrollprop toPagerWithHeaderso that the profile header can scroll with the rest of the pageiOS only. does nothing on other platforms.
Simulator.Screen.Recording.-.iPhone.16.-.2024-09-23.at.22.02.29.mp4
Test plan
Make sure android behaves the same, and make sure other list screens on iOS are unchanged (i.e. the PTR spinner is still visible)