Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video] Refactor HLS logic #5468

Merged
merged 4 commits into from
Sep 24, 2024
Merged

[Video] Refactor HLS logic #5468

merged 4 commits into from
Sep 24, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 24, 2024

Gets rid of the second effect.

Test Plan

Same as #5430.

I have not actually tested myself properly.

Copy link

github-actions bot commented Sep 24, 2024

Old size New size Diff
10.37 MB 10.37 MB 1.33 KB (0.01%)

@Zero3K
Copy link

Zero3K commented Sep 24, 2024

https://social-app-pr-5468.onrender.com/profile/phantasmajones.net/post/3l4tkpes56w22 works for me (it loops properly and the quality is good).

@arcalinea arcalinea temporarily deployed to refactor-hls - social-app PR #5468 September 24, 2024 17:25 — with Render Destroyed
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out I made an elementary error (return instead of continue in the loop) but can confirm it works now

@mozzius mozzius merged commit ddaf2c6 into main Sep 24, 2024
6 checks passed
@mozzius mozzius deleted the refactor-hls branch September 24, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants