Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scale animation for tabs #5483

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Use scale animation for tabs #5483

merged 2 commits into from
Sep 25, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Sep 25, 2024

Uses the new PressableScale for tabs

Screen.Recording.2024-09-25.at.17.56.37.mov

@mozzius mozzius requested a review from haileyok September 25, 2024 16:57
@arcalinea arcalinea temporarily deployed to samuel/scale-tabs - social-app PR #5483 September 25, 2024 16:57 — with Render Destroyed
Copy link

Old size New size Diff
10.01 MB 10.01 MB 68 B (0.00%)

Comment on lines +46 to +47
if (onPressOut) {
runOnJS(onPressOut)(e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops thanks for fixing that

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's see how it feels on device.

@mozzius mozzius merged commit 498f957 into main Sep 25, 2024
6 checks passed
@mozzius mozzius deleted the samuel/scale-tabs branch September 25, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants