[Share Extension] Move away from deprecated API, implement JS side of things #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
hailey/finish-intent-video - social-app PR #5509
Render
Destroyed
haileyok
commented
Sep 26, 2024
Comment on lines
151
to
156
| while responder != nil { | ||
| if let application = responder as? UIApplication { | ||
| return application.perform(#selector(openURL(_:)), with: url) != nil | ||
| application.open(url) | ||
| return true | ||
| } | ||
| responder = responder?.next |
There was a problem hiding this comment.
openURL is deprecated now, we'll just use application.open() instead.
arcalinea
temporarily deployed
to
hailey/finish-intent-video - social-app PR #5509
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/finish-intent-video - social-app PR #5509
Render
Destroyed
|
haileyok
commented
Sep 26, 2024
Comment on lines
241
to
+259
|
|
||
| const selectVideo = (asset: ImagePickerAsset) => { | ||
| // compression step on native converts to mp4, so no need to check there | ||
| if (isWeb) { | ||
| const mimeType = getMimeType(asset) | ||
| if (!SUPPORTED_MIME_TYPES.includes(mimeType as SupportedMimeTypes)) { | ||
| throw new Error(_(msg`Unsupported video type: ${mimeType}`)) | ||
| const selectVideo = React.useCallback( | ||
| (asset: ImagePickerAsset) => { | ||
| // compression step on native converts to mp4, so no need to check there | ||
| if (isWeb) { | ||
| const mimeType = getMimeType(asset) | ||
| if (!SUPPORTED_MIME_TYPES.includes(mimeType as SupportedMimeTypes)) { | ||
| throw new Error(_(msg`Unsupported video type: ${mimeType}`)) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dispatch({ | ||
| type: 'SetAsset', | ||
| asset, | ||
| }) | ||
| onSelectVideo(asset) | ||
| } | ||
| dispatch({ | ||
| type: 'SetAsset', | ||
| asset, | ||
| }) | ||
| onSelectVideo(asset) | ||
| }, | ||
| [_, onSelectVideo], | ||
| ) |
There was a problem hiding this comment.
No change here, just wrapping in useCallback for the effect below
mozzius
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.