Fix alt text - allow keyboard dismiss to be handled by scrollviews #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/scrollable-alt - social-app PR #5534
Render
Destroyed
|
arcalinea
temporarily deployed
to
samuel/scrollable-alt - social-app PR #5534
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/scrollable-alt - social-app PR #5534
Render
Destroyed
|
Don't need this anymore 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
keyboardDismissModeet al props on the ScrollView for dismissing keyboard rather than the jankyonTouchMove={() => Keyboard.dismiss()}on the modal containing element. Also made sure to fix it for the gif alt text modal tooTo determine - why did we use this hack in the first place??