Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle /starter-pack-short/:code in Go #5546

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Oct 1, 2024

Maybe fixes #5545. Have not verified.

@arcalinea arcalinea temporarily deployed to fix-starter-pack-url - social-app PR #5546 October 1, 2024 08:02 — with Render Destroyed
Copy link

github-actions bot commented Oct 1, 2024

Old size New size Diff
7.9 MB 7.9 MB 0 B (0.00%)

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 1, 2024

Confirmed https://social-app-pr-5546.onrender.com/starter-pack-short/5XQRRF8 works but https://bsky.app/starter-pack-short/5XQRRF8 doesn't. So I think the fix is correct.

@gaearon gaearon merged commit e33b2b1 into main Oct 1, 2024
6 checks passed
@gaearon gaearon deleted the fix-starter-pack-url branch October 1, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starter Pack short links get a 404 error
3 participants