Fix composer char progress layout #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arcalinea
temporarily deployed
to
hailey/char-prog-alt - social-app PR #5620
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w/o whitespace
Why
This if a follow up to #5611, but it also fixes some things that I realized are existent even in production right now.
For example, currently the language selector will jitter around as we type since the layout is shifting each time the character count updates (different chars take up different amounts of space). I'll be addressing that here as well as fixing the actual bug right now (bad layout, number shows above the wheel rather than to the left of it, oops!)
Test Plan
Check each progress wheel/counter in each part of the app on both native and web.
Composer
Web
Screen.Recording.2024-10-05.at.2.00.47.PM.mov
Native
RocketSim_Recording_iPhone_16_Pro_6.3_2024-10-05_14.13.41.mp4
Report Dialog
Web
Screen.Recording.2024-10-05.at.2.19.15.PM.mov
Native
RocketSim_Recording_iPhone_16_Pro_6.3_2024-10-05_14.18.22.mp4
Alt Text Dialog
Web
Screen.Recording.2024-10-05.at.2.15.05.PM.mov
Native
RocketSim_Recording_iPhone_16_Pro_6.3_2024-10-05_14.16.40.mp4