Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bounce when expanding sheet on ios #5627

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Fix bounce when expanding sheet on ios #5627

merged 2 commits into from
Oct 6, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Oct 6, 2024

No description provided.

Copy link

github-actions bot commented Oct 6, 2024

The Pull Request introduced fingerprint changes against the base commit:

Fingerprint diff
[{"type":"dir","filePath":"modules/bottom-sheet/ios","reasons":["expoAutolinkingIos"],"hash":"c1dcfbe7e47bc03e1d0ef0841ef7680c31444170"}]

Generated by PR labeler 🤖

Copy link

github-actions bot commented Oct 6, 2024

Old size New size Diff
7.92 MB 7.92 MB 0 B (0.00%)

@haileyok haileyok changed the title Fix bounce when expanding sheet Fix bounce when expanding sheet on ios Oct 6, 2024
@arcalinea arcalinea temporarily deployed to hailey/fix-bounce - social-app PR #5627 October 6, 2024 18:47 — with Render Destroyed
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right, have not tested

@haileyok haileyok merged commit 686dfa5 into main Oct 6, 2024
6 checks passed
@haileyok haileyok deleted the hailey/fix-bounce branch October 6, 2024 19:03
@haileyok
Copy link
Contributor Author

haileyok commented Oct 6, 2024

Will let it run now so we can test on device. Worked in sim at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants