New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncontrol search inputs #5659

Open

mozzius wants to merge 4 commits into main from samuel/uncontrol-search

Member

mozzius commented Oct 9, 2024

Makes the clear button support being uncontrolled
Uncontrols all search inputs except for the main one (which has good enough reasons to be controlled, unfortunately)

mozzius added 3 commits

October 9, 2024 07:30


          make SearchInput handle clearing by itself

39efd9f


          uncontrol simple search inputs

8a605d8


          remove need to set query to '' on clear

130edab

arcalinea temporarily deployed to samuel/uncontrol-search - social-app PR #5659

October 9, 2024 04:33

— with

Render Destroyed


          call onClearText

1697c0b

arcalinea deployed to samuel/uncontrol-search - social-app PR #5659

October 9, 2024 04:34

— with

Render View deployment

mozzius requested a review from haileyok

October 9, 2024 04:34

github-actions bot commented Oct 9, 2024

Old size	New size	Diff
7.89 MB	7.89 MB	61 B (0.00%)

arcalinea deployed to samuel/uncontrol-search - social-app PR #5659

October 12, 2024 19:12

— with

Render View deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet