Move all portaling logic into BottomSheet, remove from our own Dialog wrapper
#5661
Conversation
| }, | ||
| ]}> | ||
| <View onLayout={this.updateLayout}> | ||
| <BottomSheetPortalProvider>{children}</BottomSheetPortalProvider> |
There was a problem hiding this comment.
All the children get their own portal provider, so that any dialogs inside of here get put in the right place.
| } | ||
|
|
||
| return ( | ||
| <Portal> |
There was a problem hiding this comment.
Whatever the closest portal is we'll wrap the native component with.
|
| <View onLayout={this.updateLayout}>{children}</View> | ||
| </View> | ||
| </NativeView> | ||
| if (__DEV__ && !Portal) { |
There was a problem hiding this comment.
DEV-only throws are generally something to avoid because this significantly changes the code path in production. It means that if someone were to hit this in prod, they would see completely different behavior. So it would be hard to diagnose. In some cases, it can be worse than crashing — for example if it accidentally uncovers a bug that causes some bigger problems (like losing or misinterpreting user data). I don’t mean that this would happen here but we should take it as a rule to throw both in PROD and DEV when we do throw. Or it needs to change to be non-throwing.
No description provided.