[Sheets] Allow specifying an initial height #5669
Draft
+86
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"dir","filePath":"modules/bottom-sheet/android","reasons":["expoAutolinkingAndroid"],"hash":"30e5806c53396f6007e16a780ba6881706781c23"},{"type":"dir","filePath":"modules/bottom-sheet/ios","reasons":["expoAutolinkingIos"],"hash":"a630f462f5c93a5d5f670dc95d79508d603fdb1e"}]Generated by PR labeler 🤖 |
|
mozzius
commented
Oct 10, 2024
Comment on lines
+57
to
+63
| if initialHeight == "half" { | ||
| if (screenHeight - 100) / 2 > contentHeight { | ||
| sheet.detents.insert(.medium(), at: 0) | ||
| } else { | ||
| sheet.detents.append(.medium()) | ||
| } | ||
| } |
There was a problem hiding this comment.
This part is sus, I don't know the proper way to determine the real height of .medium. Docs say they have to be ordered but I don't know what the consequences are of it not being ordered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
initialHeightprop to the iOS sheets which allows them to open at half or full size initiallyI wasn't able to see how you'd go about doing this on Android
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-10.at.16.42.48.mp4